-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4618/#review6528
-----------------------------------------------------------

Ship it!


to me is ok.
only thing would be it's becoming a stack a bit too high to fit in panels, but 
since it's off by default, that's fine

- Marco


On 2010-07-13 13:29:30, Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2010-07-13 13:29:30)
> 
> 
> Review request for Plasma, Frederik Gladhorn and Alexis Menard.
> 
> 
> Summary
> -------
> 
> Trivial patch that adds a "switch user" button. I tried to follow the coding 
> style that was already present.
> 
> For users that use the lock/logout buttons but don't use kickoff, there is no 
> easily discoverable way to switch users. They have to lock their session, get 
> the unlock dialog to appear and then click the button "switch user..." button 
> there.
> 
> Most of the strings as well as the code that interfaces with krunner has been 
> taken from the kickoff applet.
> 
> 
> This addresses bug 228993.
>     https://bugs.kde.org/show_bug.cgi?id=228993
> 
> 
> Diffs
> -----
> 
>   
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/CMakeLists.txt
>  1149404 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 
> 1149404 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 
> 1149404 
>   
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockoutConfig.ui
>  1149404 
> 
> Diff: http://reviewboard.kde.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ingomar
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to