----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4522/#review6379 -----------------------------------------------------------
Ship it! looks completely sensible to me. - Aaron On 2010-07-05 18:31:20, Beat Wolf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4522/ > ----------------------------------------------------------- > > (Updated 2010-07-05 18:31:20) > > > Review request for Plasma. > > > Summary > ------- > > Recalculate the current desktop size in kephal and don't trust QDesktopwidget > on that one. > Solves an issue that the current desktop size is wrong just after the screen > added signal has been received. > > Solves the bug in pager where the aspect ratio is not changed correctly when > adding and removing a screen. > > Of course cashing could be done, but since there are usualy only 1-2 screens > and that method is not used often, it should be just fine like that. > > PS: the withespace thing will be corrected when i commit > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/kephal/kephal/screens.cpp 1146308 > > Diff: http://reviewboard.kde.org/r/4522/diff > > > Testing > ------- > > Tested with a second screen > > > Thanks, > > Beat > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
