bam added inline comments.

INLINE COMMENTS

> workspaceoptions_plasmasettings.kcfg:14
> +  <group name="OSD">
> +    <entry name="osdEnabled" key="Enabled" type="Bool">
> +      <label>Display visual feedback for status changes</label>

Could we share it with the consumer of this setting itself in P-W? Currently it 
uses legacy way to access it's setting and thus can become out of sync easily:
https://invent.kde.org/plasma/plasma-workspace/-/blob/master/shell/osd.cpp#L161

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25586

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: bam, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to