sandsmark added a comment.

  > It's all C code whereas the rest of the helper is C++. It also relies very 
heavily on magic numbers now.
  
  
  
  > I think a much simpler implementation would be to split each line on " ", 
select the fields we want and clean them up.
  
  I assume this is for performance reasons, but a tiny microbenchmark showing 
that it is actually faster would be nice.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

To: dkorth, ahiemstra
Cc: sandsmark, ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Reply via email to