----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4265/#review6055 -----------------------------------------------------------
Ship it! looks good, and one more bug down for 4.5 :) /trunk/KDE/kdeplasma-addons/applets/qalculate/qalculate_history.cpp <http://reviewboard.kde.org/r/4265/#comment5638> these changes aren't part of the fix, correct? just clean ups? - Aaron On 2010-06-09 14:22:07, Matteo Agostinelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4265/ > ----------------------------------------------------------- > > (Updated 2010-06-09 14:22:07) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes a crash when browsing the history in the Qalculate plasmoid. > The crash can be reproduced by activating the input line in the applet and > then pressing an arrow key (up or down). It fixes bug > http://bugs.kde.org/show_bug.cgi?id=241006 > > > This addresses bug 241006. > https://bugs.kde.org/show_bug.cgi?id=241006 > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/qalculate/qalculate_history.cpp 1132579 > > Diff: http://reviewboard.kde.org/r/4265/diff > > > Testing > ------- > > Tested with no crashes > > > Thanks, > > Matteo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
