ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
So this only fixes the problem when the POTD image has already been cached by the plugin for the desktop wallpaper? While the patch would fix that particular use case, I don't think that's a general purpose solution, and if we do implement a general-purpose solution, we won't have to do this. So I think we should focus on the general solution, sorry. Maybe we can have kded or another already-running daemon perform the caching? INLINE COMMENTS > cachedprovider.cpp:54 > const QString path = CachedProvider::identifierToPath( m_identifier ); > - m_image.save(path, "PNG"); > + m_image.save(path, "JPEG"); > emit done( m_identifier, path, m_image ); seems unrelated REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
