> On 2010-06-07 17:41:01, Aaron Seigo wrote: > > this is how all the plasmoid configuration dialogs are done. it should, in > > fact, be how all KDE config dialogs are done, imho, due to alignment and > > visual scanning issues, but i don't have the energy right now to try and > > persuade the conservative and self-confident KDE community. > > Hugo Pereira Da Costa wrote: > mmm. It is not consistent with the "share" tab of all the plasmoids I > looked at. Or did I miss something ? Also, what should then be the alignment > of checkboxes in lists ? > Anyway. I don't care that much (so long for the self confidence). > I'm more concerned about consistency rather than what the "correct" > layout is. > > > Hugo Pereira Da Costa wrote: > oh. And checkboxes in menus are on the left too.
"It is not consistent with the "share" tab of all the plasmoids I looked at." yes, something that needs to be fixed in 4.6 along with some other notable inconsistencies. "checkboxes in menus are on the left too. " menus and dialog layouts are completely different beasts. dialogs have to contend with some widgets only making sense on the right (e.g. label + combobox or spinbox) and provide a dense collection of "what this does" labels related to "here's where you can do it" objects. menus are far simpler lists of actions. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4246/#review6020 ----------------------------------------------------------- On 2010-06-06 21:07:54, Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4246/ > ----------------------------------------------------------- > > (Updated 2010-06-06 21:07:54) > > > Review request for Plasma. > > > Summary > ------- > > In the current "notifications" config page, checkboxes are presented with > right aligned labels, and checkboxes on the right of these labels. As far as > I know, this layout is used nowhere else in various UIs, and neither me nor > Pinheiro could find a reason for this unusual layout. Is there any ? > This patch restores "normal" layout, with checkboxes on the left, and > left-aligned labels, right of the checkbox. > See screenshots. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationsconfig.ui > 1135215 > > Diff: http://reviewboard.kde.org/r/4246/diff > > > Testing > ------- > > oxygen + trunk > > > Screenshots > ----------- > > current layout > http://reviewboard.kde.org/r/4246/s/425/ > proposed layout > http://reviewboard.kde.org/r/4246/s/426/ > > > Thanks, > > Hugo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
