romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  > Docs explicitly say this.
  
  When you reference some "docs" please take 20 seconds and directly link it. 
Every piece you write here and in git commit messages is potentially read by 
hundreds of other people. If you link the source once you save dozens of 
man-hours of other people looking the information up afterwards. Or they might 
decide to not look it up because it's too much hassle -> onboarding.
  
  Thanks for looking into that issue. lgtm without further delay, I trust you 
on your QML expertise.

INLINE COMMENTS

> Output.qml:60
> -    color: palette.window
> -    smooth: true
>  

Is the change making this unnecessary? I.e. do the graphics still look "smooth"?

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29340

To: davidedmundson, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to