davidedmundson added a comment.

  I don't like this "assistant" object that is just an opaque pointer being 
passed around from QML space. It's not very declarative.
  
  Either we should register this item as a singleton with some nice invokable 
methods to show KNS dialogs, which could be a nice useful re-usable class. Then 
we port WidgetExplorer.qml to use that directly
  
  Or just internally make widgetexplorerassistant some static inside 
WidgetExplorer as a completely private class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28878

To: sunny, #plasma
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to