bport accepted this revision.
bport added a comment.

  OK for me, as long as VDG is ok with this behavior

INLINE COMMENTS

> fonts.cpp:272
> +        const int generalFontPointSize = font.pointSize();
> +        if (generalFontPointSize > 8) {
> +            smallestFont.setPointSize(generalFontPointSize - 2);

Nit-pick can we align comment and code either higher than 8pt (comment) or >= 9 
on the code

REPOSITORY
  R119 Plasma Desktop

BRANCH
  make-small-font-smaller-when-changing-all-font-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to