broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> iconapplet.cpp:354
> connect(action, &QAction::triggered, this, [this, exec] {
> KRun::run(exec, {}, nullptr, m_name, m_iconName);
> });
Just FTR this could also get some `KServiceAction` treatment
> appentry.cpp:42
> +#include <KNotificationJobUiDelegate>
> #include <KRun>
> #include <KSycoca>
Looks unused now?
> recentusagemodel.cpp:44
> +#include <KNotificationJobUiDelegate>
> #include <KRun>
> #include <KService>
Unused?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29124
To: dfaure, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
