cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:88
> Not sure it's actually a bug in the multi-page KCM system as @iasensio was 
> able to make this work properly in D28152 
> <https://phabricator.kde.org/D28152>. Maybe you can see what he did there?

Seems to work for me now.

> ngraham wrote in user_manager.desktop:9
> You've moved it out of the Account details group. If this is intentional, 
> then we also need to move the KWallet KCM out of that group, or else Account 
> details has only one item and shows the KWallet KCM when clicked on, which is 
> confusing because the second level of navigation is collapsed and the group 
> name doesn't match the KCM name.
> 
> F8249318: Screenshot_20200420_081303.png 
> <https://phabricator.kde.org/F8249318>
> 
> So move it back into the Account Details group or submit another patch to 
> move KWallet out of the group too.

Will do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to