ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcm.cpp:315
> ManagedConfigModule::defaults();
> - m_settings->defaults();
> + for (auto *behaviorSettings : m_behaviorSettingsList) {
> + behaviorSettings->setDefaults();
qAsConst(m_behaviorSettingsList), otherwise it will unfortunately detach.
> kcm.cpp:334
> + bool notDefault = std::any_of(m_behaviorSettingsList.cbegin(),
> + m_behaviorSettingsList.cend(),
> + [](const
> NotificationManager::BehaviorSettings *settings) { return
> !settings->isDefaults(); });
I'd align that (and the next line) with the previous parameter.
> kcm.cpp:335
> + m_behaviorSettingsList.cend(),
> + [](const
> NotificationManager::BehaviorSettings *settings) { return
> !settings->isDefaults(); });
> + return !notDefault;
This starts being a long line, please break it after the opening brace and
again after the first semicolon.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27188
To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
