broulik added inline comments. INLINE COMMENTS
> PlaceholderMessage.qml:118 > + */ > + property QQC2.Action helperAction > + You can probably just make an `alias` to the button's `action` property. It got added in Qt 5.10, then it should take on the icon, text, visibility, trigger, etc of that action automatically. (`helperAction` sounds as if it were an implementation detail somehow) > PlaceholderMessage.qml:141 > + > + visible: root.icon != undefined && root.icon.length > 0 > + opacity: 0.5 Probably just want to bind `valid` > PlaceholderMessage.qml:148 > + > + Layout.alignment: Qt.AlignHCenter > + horizontalAlignment: Qt.AlignHCenter `Layout.fillWidth: true` instead, so it'll wrap properly? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
