fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Tested, works. I didn't even notice that it broke...
  
  Will probably have to be refactored later to look at 
`environmentDescriptions` or `environmentNames` though.
  
  > Should be good for 5.18 - coreaddons should have been an implicit 
dependency anyway?
  
  Yup.
  
  > Its icon doesn't show up and I have no idea where the "vivadi" icon file it 
specifies in its desktop file is located
  
  Here it used `xdg-icon-resource install ...` to install the icon in an rpm 
%post script, so I've got `/usr/share/icons/hicolor/*x*/apps/vivaldi.png` as 
usual.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28893

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to