cblack added inline comments. INLINE COMMENTS
> mart wrote in Page.qml:238 > again, not convinced we should have this, seems a bit oddly specific it's not uncommon for apps to have one page associated with an ongoing task. examples: - clocks app running a progress indicator in reverse to indicate a timer - app store running a progress indicator on "updates/downloads" tab - gallery/online drive app running a progress indicator on a tab to indicate syncing progress > mart wrote in SwipeNavigator.qml:30 > perhaps any custom heading should be via a custom item (or component?) to put > as a property (of type qqc2.tabbar) i don't see how that relates to wanting a larger (bigscreen-sized) header? > mart wrote in SwipeNavigator.qml:55 > different tabbars should really depend only on whether it's a mobile device > or not (and be at bottom if mobile): a very small window on desktop is not a > mobile app it's still nice to have a collapsed form of the tabbar for small screen sizes > mart wrote in SwipeNavigator.qml:66 > this should be page actions? other actions? what is the exact use case? global actions > mart wrote in SwipeTabBar.qml:12 > QtQuickControls do have a TabBar control, instead of having a completely > custom control I'm aware, but I went with a custom control for more control of the presentation and functionality. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson
