davidre added subscribers: dfaure, davidre. davidre added a comment.
This causes expired notifications to not vanish any more. This is supposed to work in the following way `ExpiredRole` is assigned `true` and `NotficiationFilterProxyModel` filters expired notifications out. I verified that upon timeout of the timer the data is updated correctly but the filter model behaves in a strange way. Even though filterAcceptsRow returns false the model still includes the index. I added the following debug output to the class: https://phabricator.kde.org/P584 Which results in this debug output QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired QModelIndex(-1,-1,0x0,QObject(0x0)) not expired rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) QModelIndex(-1,-1,0x0,QObject(0x0)) 1 QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false rowCount NotificationManager::NotificationFilterProxyModel(0x557a51f6ab00) QModelIndex(-1,-1,0x0,QObject(0x0)) 1 QModelIndex(0,0,0x0,QConcatenateTablesProxyModel(0x557a51b00d90)) is expired filter returns for filterAcceptsRow(index(0, mapToSource(parent)) false So it still has one row even though the first row should get filtered. Adding @dfaure because he wrote both K/QConcatenate... models REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
