romangg added a comment.
Conceptually makes sense. +1 form me on that. Good solution. Thanks for outlining it in the summary. This patch can land with a fix for the view leak or without. I accept when my inline comments are fixed. @davidedmundson: can you give a quick accept on the solution from PlasmaQuick pov? INLINE COMMENTS > output_identifier.cpp:54 > + qmlObject->completeInitialization(); > + auto rootObj = qobject_cast<QQuickItem *>(qmlObject->rootObject()); > + view->setMainItem(rootObj); This part could use some empty lines. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport, #plasma, romangg Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
