broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY I recall we originally didn't do it when Noah added these icons as `browserAction.setIcon` wasn't able to override the icon or something like this? However, it doesn't appear to be the case anymore in more recent versions. While the `setIcons` API doesn't support theme icons, only set the custom icon when the extension fails to start. So let's not jeopardize the normal user experience by this edge case. TEST PLAN Tool bar icon is now readable in dark mode F8234329: Screenshot_20200413_210913.png <https://phabricator.kde.org/F8234329> Chrome just ignores the key REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28806 AFFECTED FILES extension/manifest.json To: broulik, #plasma, fvogt, ognarb, ndavis Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
