broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This mutates the source array. In practice actions don't really change in existing notifications but still better to not do that. TEST PLAN 5.18? Did some grouping popups thing and my buttons don't randomly shuffle anymore Maybe that could also have been the cause for the kde connect buttons being swapped? Though I think that's not on our side. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28650 AFFECTED FILES applets/notifications/package/contents/ui/NotificationItem.qml To: broulik, #plasma, nicolasfella Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart