jgrulich added inline comments.

INLINE COMMENTS

> apol wrote in background.cpp:69
> I don't really understand why we're exposing this. Is it for contained apps?

This is actually not API exposed to the clients, this is purely for 
xdg-desktop-portal needs, while the client interface (xdg-desktop-portal) has 
limited stuff available, see 
https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Background.xml.

> apol wrote in background.cpp:194
> Will dbus look in autostart though?

Doesn't need to? I think it just specifies that the desktop file should ignore 
the exec line and start it through DBus (assuming correct dbus service file is 
installed etc.). Or am I wrong?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to