cblack added inline comments. INLINE COMMENTS
> mart wrote in pagerouter.h:12 > is this still needed for routes that are a composition of PageRoute objects > like /path/to/some/thing? This is an internal struct for keeping track of internal state and to have a C++ representation of a a QJSValue that may not correspond to a PageRoute object declared by the user. Compare by struct values instead of compare by pointer reference is used here as well. > mart wrote in pagerouter.h:66 > since is per page this global property should go The global property is already gone, this is the per-page property > mart wrote in pagerouter.h:91 > any reason this should be a qquickitem? > > this doesn't display things per se, neither should be a parent of items, but > just to remote control a given pagerow, it should be a QObject componentComplete is used to ensure that everything is parsed only when QML is done, not when the object is created > mart wrote in pagerouter.h:114 > Q_PROPERTY(QString initialRoute (provided the route name is unique, which > should be checked and some type of error thrown if not) The initial route can have data REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28383 To: cblack, #kirigami, mart, davidedmundson Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, mart
