dfaure added a comment.
> I kinda feel CommandLauncherJob should have a QString executable, QStringList args constructor so I don't have to escape things myself? Sounds good, excellent idea. This would simplify the code in many callers. Please add :) It still needs to support the "QString command" use case though, since that's sometimes what we have as input. Well, at least for KRun::runCommand, but we can keep that public for other use cases I guess (exec lines extracted from desktop/config files, inputted by users etc.). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28512 To: broulik, #plasma, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
