ngraham added a comment.

  You should set `smooth: true` on those avatars in the new gallery so they 
aren't so jaggy. Also the button to add your own avatar from a file should 
probably have a label in it so people can figure out what it does. And the 
sheet that the new gallery is on should be wider; right now it's really narrow 
with the default System Settings window width. And the only avatars in the 
gallery are Konqis; what happened to the other ones? Finally I notice that 
selecting any of the avatars in the gallery resets the avatar display on the 
details page to the default one rather than reflecting the one you chose.
  
  Ooh and here's something I just remembered: we should mask the avatar into a 
circle like Kickoff and the lock/login/logout screens do. You can probably just 
lift the code straight from Kickoff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to