mart added a comment.
almost good, just two minor nitpicks INLINE COMMENTS > PagePoolAction.qml:57 > + */ > + property var properties > + initialProperties > pagepool.cpp:160 > + > +class PropertyInitializingIncubator : public QQmlIncubator > +{ put a comment that as soon we can depend from Qt 5.14 we should remove this incubator and use QQmlComponent::createWithInitialProperties instead REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28468 To: masonm, #kirigami, mart Cc: plasma-devel, mart, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson