> On 2010-05-21 15:43:26, Aaron Seigo wrote: > > unfortunately it's too late for 4.5 due to the string freeze, but this > > should go into 4.6. in fact, i'd like to see it change from being the last > > plugged in device to perhaps a list of all devices plugged in along with > > their mount status? battery, screen resize, audio, etc. are all providing > > useful "snapshot" information in their tooltips these days, and i feel that > > the device notifier's tooltip would be more useful if it gave a more > > accurate idea of what's what. what do you think? > > Ignat Semenov wrote: > Well, as far as device notifier goes, there's a couple more things about > it that I'd like to see fixed as well. This one about tooltips sounds nice, > but then it kinda duplicates what's in the real device list, and there seems > to be a limitation on the tooltip size (is there?) Really don't know what's > the best one, maybe a very compact list would work. > Then, there's one more point: kill those separators (it's time to get rid > of them in a lot of places, I think :), and squeeze the "Available devices" > with the icon vertically. There's too much margin space on both sides. All > pure aesthetics, but then, it's screen space and clutter. If you don't mind, > I'll hack on this, and deliver a prototype of device list popup for the > applet.
> there seems to be a limitation on the tooltip size there isn't. > a very compact list would work yes; it should only list pluggable devices (not devices that are always attached; which can be optionally shown), and there shouldn't be too many of those > kill those separator which separators? > squeeze the "Available devices" with the icon vertically can you provide some mockups and/or annotated screenshots showing what you mean? just to avoid unecessary work in case what you are looking to change has a reason for being that way :) > If you don't mind, I'll hack on this, and deliver a prototype of device list > popup for the applet people hacking on things is always good :) let's move the rest of this discussion to plasma-devel, and i'll mark this particular item as "discarded" for now. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4100/#review5806 ----------------------------------------------------------- On 2010-05-21 15:15:38, Ignat Semenov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4100/ > ----------------------------------------------------------- > > (Updated 2010-05-21 15:15:38) > > > Review request for Plasma. > > > Summary > ------- > > Currently, device notifier tooltips use normal text. while all other plasma > tooltips have main text and subtext. To enforce consistency, I've changed it > to use main text for "Most recent device" and subtext for the rest. However, > I'm not sure if it's OK from string freeze point of view, as I've broken a > string in two and killed a dot. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp > 1128711 > > Diff: http://reviewboard.kde.org/r/4100/diff > > > Testing > ------- > > Device Notifier tooltip looks fine now. > > > Thanks, > > Ignat > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
