alex added a comment.
In D28439#638188 <https://phabricator.kde.org/D28439#638188>, @davidedmundson wrote: > QIcon isn't thread safe. Sorry, I wasn't aware about that and haven't found anything when I had a quick look at the docs before submitting this patch. But if I may ask: Why is this now not thread save but was before? Before this patch the icon was created in the BookmarkMatch::asQueryMatch method which was called from the secondary thread. And with this patch the icon gets created in the Browser::match method which gets called from the same thread. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
