apol added a comment.
Other than that, the patch looks good. +1 INLINE COMMENTS > romangg wrote in CMakeLists.txt:23 > Any idea how to reuse the declaration from the top-directory CMake file? Make sure the include() call is before the add_subdirectory(). That's why we usually put them together on top right under the find_package() together with `include(ECMGenerateHeaders)`. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
