----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4033/#review5731 -----------------------------------------------------------
The patch is really small, and it's working at least with all default color schemes KDE comes with, and also the affected part of the interface IS NOT plasmified, so I'm going to commit the patch. Sorry for the noise :p - Alex On 2010-05-18 14:19:16, Alex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4033/ > ----------------------------------------------------------- > > (Updated 2010-05-18 14:19:16) > > > Review request for Plasma, Aaron Seigo and wilder. > > > Summary > ------- > > The MatchView interface of QuickSand (where the found items are displayed as > a vertical list) is hardcoding the text color (black), so when switching to a > dark color scheme it's unusable. > > The patch remove 2 lines, the FIXME and the actual code which hardcode the > color. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.cpp > 1127908 > > Diff: http://reviewboard.kde.org/r/4033/diff > > > Testing > ------- > > I have test it with Oxygen and coast, the color and background used is the > one defined by the schema, so it's ok. > > > Thanks, > > Alex > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
