hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1687
> +        while (parent != nullptr) {
> +            if (qobject_cast<const QMdiArea*>(widget) || qobject_cast<const 
> QDockWidget*>(widget)) {
> +                return false;

mmm shouldn't you test on parent rather than widget here ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to