----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4032/#review5721 -----------------------------------------------------------
Ship it! looks good; these kinds of simple fixes just can be committed directly w/out review, imho - Aaron On 2010-05-18 14:08:02, Alex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4032/ > ----------------------------------------------------------- > > (Updated 2010-05-18 14:08:02) > > > Review request for Plasma, Aaron Seigo and wilder. > > > Summary > ------- > > Quicksand is always showed in the same screen. > > The problem is that QuickSand is calling QWidget::show before > KRunnerDialog::positionOnScreen, so when positionOnScreen check if the dialog > isVisible, true is always returned (so the screen is never refreshed). > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp > 1127908 > > Diff: http://reviewboard.kde.org/r/4032/diff > > > Testing > ------- > > > Thanks, > > Alex > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
