ngraham accepted this revision. ngraham added a reviewer: drosca. ngraham added a subscriber: drosca. ngraham added a comment. This revision is now accepted and ready to land.
This looks great to me! I have to admit I was skeptical when I first saw the patch, but I think making the options very granular like this actually helps to explain just what they'll do, and also disambiguates the visual vs audible feedback settings too. #plasma <https://phabricator.kde.org/tag/plasma/> people and/or @drosca, are folks okay with this? REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik, ngraham, drosca Cc: drosca, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
