mart added inline comments.
INLINE COMMENTS
> kquickstyleitem.cpp:218
> opt->icon = QIcon(icon.value<QUrl>().toLocalFile());
> + } else if (icon.canConvert<QUrl>() && icon.value<QUrl>().scheme() ==
> QLatin1String("qrc")) {
> + const QString iconUrl = icon.value<QString>().mid(3);
should it also catch the ":/foo" case?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D28194
To: nicolasfella, #plasma, mart
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
