meven accepted this revision. meven added a comment. This revision is now accepted and ready to land.
Minor nitpick So the code basically extracts from KillRunnerConfigForm the Config constants. INLINE COMMENTS > killrunner.cpp:65 > > - m_sorting = (KillRunnerConfig::Sort) grp.readEntry(CONFIG_SORTING, 0); > + m_sorting = (Sort) grp.readEntry(CONFIG_SORTING, 0); > QList<Plasma::RunnerSyntax> syntaxes; You can use the enum as default value here I guess : Sort::NONE REPOSITORY R120 Plasma Workspace BRANCH killrunner_config_refactoring REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
