broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> servicerunner.cpp:114
> + for(int i = 1; i < strList.size(); ++i) {
> + const auto &str = strList[i];
> if (category == QLatin1String("Name")) {
Perhaps use `.at(i)`
> servicerunner.cpp:464
>
> - QMimeData *data = new QMimeData();
> + auto data = new QMimeData();
> data->setUrls(QList<QUrl>{QUrl::fromLocalFile(path)});
Keep the `*` :p
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28138
To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
