----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3953/#review5579 -----------------------------------------------------------
Ship it! it's unfortunate that we can't define some set parameters that could be used in custom stylesheets, but it seems CSS is a bit wonky that way and requires styles to be applied to known elements ... which means this kind of search-n-replace :/ oh well ... it's a useful feature for making things look proper. in it goes :) /trunk/KDE/kdelibs/plasma/theme.cpp <http://reviewboard.kde.org/r/3953/#comment5262> should have a space there: foreach (const QString &k; could also be done with a QHashIterator, but that's a 6-of-one-half-dozen-of-another kind of thing.. - Aaron On 2010-05-11 00:33:35, Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3953/ > ----------------------------------------------------------- > > (Updated 2010-05-11 00:33:35) > > > Review request for Plasma and Marco Martin. > > > Summary > ------- > > Plasma::Theme-themed stylesheets for use in hybrid web/native plasma widgets. > > This new API provides a simple default stylesheet in Plasma colors, but can > also be used to theme custom, more elaborate stylesheets. > > As discussed during Tokamak4, and with Marco on the plasma-devel list. For > 4.5. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/theme.h 1124963 > /trunk/KDE/kdelibs/plasma/theme.cpp 1124963 > > Diff: http://reviewboard.kde.org/r/3953/diff > > > Testing > ------- > > basic testing > > > Thanks, > > Sebastian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
