dvratil marked an inline comment as done.
dvratil added inline comments.

INLINE COMMENTS

> romangg wrote in waylandbackend.cpp:81
> Let the backend populate the Private here is unusual, or is it not? On the 
> other side it makes sense. Let the consumer only access the public interface 
> and the backend access the private one. I don't know what's the commonly used 
> approach to that in Qt dev. Out of interest you can say? In any case we can 
> leave it like that for now.

I found this to be the simplest solution to avoid exposing some setters/factory 
functions into `Edid'`public interface. It's all internal code, so no risk of 
API/ABI breakages...

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to