kmaterka added inline comments.

INLINE COMMENTS
> cblack wrote in ExpandedRepresentation.qml:261
> This advice doesn't seem to be applicable here, as the `implicitWidth` of the 
> ColumnLayout child isn't able to be mutated due to the fact that all of its 
> child items (text) have fixed `implicitWidth`s.

True, I didn't want to copy whole answer from Stack Overflow :) In this case 
`Layout.preferredWidth` should not be set to `parent.width / 2`, better to use 
`Layout.preferredWidth = 50`. I sometimes add % in a comment: 
`Layout.preferredWidth = 50//%`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin, ngraham
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to