ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
LGTM, modulo some small string change requests. Obviously this can't go in
until and unless the dependent patch lands. :)
INLINE COMMENTS
> main.qml:206
> + Layout.fillWidth: true
> + text: dndToMoveEnabler.checked ? i18n("Hold Shift when dropping
> to show the menu") : i18n("")
> + elide: Text.ElideRight
Maybe "Hold Shift when dropping to show drop options"
> workspaceoptions_kdeglobalssettings.kcfg:13
> + <entry name="dndToMove" key="dndToMove" type="Bool">
> + <label>Drag and drop files will move files</label>
> + <default>false</default>
No reason to be terse here; this should be as descriptive as needed. For
example:
For local files on the same device, whether dragging and dropping will perform
a move operation instead of showing the options menu
REPOSITORY
R119 Plasma Desktop
BRANCH
add-dndToMove (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27998
To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
