ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kstart.cpp:184
> Wouldn't it be easier here to just do `windowtitle.compare(info.name(), 
> Qt::CaseInsensitive)` and skip the regex?

I thought about that, but looking at the code I found:

  void KStart::sendRule() {
      KXMessages msg;
      QString message;
      if( !windowtitle.isEmpty() )
          message += QStringLiteral("title=") + windowtitle + 
QStringLiteral("\ntitlematch=3\n"); // 3 = regexp match

which made me leave the regex in...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28000

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to