ngraham added a comment.
In D27979#625943 <https://phabricator.kde.org/D27979#625943>, @niccolove wrote: > In D27979#625809 <https://phabricator.kde.org/D27979#625809>, @broulik wrote: > > > Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications > > > Yepp, I did test it with various notifications. > > In D27979#625865 <https://phabricator.kde.org/D27979#625865>, @ngraham wrote: > > > Please test to make sure that your patches work :) > > > I do! But since I was unable to add that class to my local framework If it doesn't work for you, that's a good bet it won't work for other people either, which means it can't actually be tested and merged. :) Whatever is preventing it from working when you integrate it in the correct way is a bug that needs to be fixed so that the patch is testable and merge-able, not something you can hack around. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27979 To: niccolove, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
