ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Looks sexy as hell. I think the icon inside the notification needs to be
moved or resized though. Right now it has no top padding, so it touches the
header.
INLINE COMMENTS
> NotificationItem.qml:114
>
> - NotificationHeader {
> - id: notificationHeading
> - Layout.fillWidth: true
> + PlasmaComponents.TopArea{
> + bottomInset: Math.round(thumbnailTopPadding / 2)
needs to be `PlasmaExtras.PlasmoidHeading` now, since it was renamed and moved
to `PlasmaExtras`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27697
To: niccolove, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
