----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3896/#review5430 -----------------------------------------------------------
Ship it! to me seems the correct way to proceed. trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop <http://reviewboard.kde.org/r/3896/#comment5119> add yourself here :) - Marco On 2010-05-05 16:10:45, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3896/ > ----------------------------------------------------------- > > (Updated 2010-05-05 16:10:45) > > > Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart. > > > Summary > ------- > > This patch provides a dataengine which collects and exposes (un)mounting > error notifications; the plasma devicenotifier will spawn an instance of this > dataengine to tell knotify that it will display such notifications itself. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt > 1123205 > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/3896/diff > > > Testing > ------- > > This patch depends on the corresponding one for knotify; > > With that patch it works as expected. > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
