> On 2010-05-03 17:32:50, Marco Martin wrote: > > can you commit it? then I'll change the icon afterwards
Yep, okay. Done in r1122520. - Harsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3857/#review5376 ----------------------------------------------------------- On 2010-05-01 10:15:44, Harsh J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3857/ > ----------------------------------------------------------- > > (Updated 2010-05-01 10:15:44) > > > Review request for Plasma and usability. > > > Summary > ------- > > First off, this is more of a personal suggestion than a bug-fix/etc :) > > As the notification tray item is already such a tiny thing and has newly > introduced (cool) animation effects for running job's completion progresses, > squeezing a label within like "running / total" only crowds it more. The > animation looks pretty weird around it. > > Why not just show total remaining jobs and keep counting down at that, much > like those loading screens in the old movies that went "5.. 4.. 3.. 2.. 1.. > (i).". This so cause at every job completion a notification event is anyway > supposed to fire (whether user has set to receive it or not) and the shown > number also indicates automatically the no. of jobs left to do -- the user > will anyway have to click the icon for detailed information on what is/how > many are actually progressing. So lets just show total no. of remaining jobs > to run. Comments? > > P.s. Something can also be done to enhance the look of those numbers ("1/2" > or even if its just "2"). But the result shouldn't hinder the bg animation, > and I can't think of what will do both :\ > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/busywidget.cpp > 1121172 > > Diff: http://reviewboard.kde.org/r/3857/diff > > > Testing > ------- > > Ran several jobs to see it count down after the notification pops up. Trivial > change I think? > > > Screenshots > ----------- > > Icon with just total displayed, over the bg animation -- instead of running / > total. > http://reviewboard.kde.org/r/3857/s/383/ > > > Thanks, > > Harsh > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
