kmaterka added a comment.
In D27466#620470 <https://phabricator.kde.org/D27466#620470>, @gvgeo wrote: > IMO this is the wrong way to do these changes. > > 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place. > 2. For tablets already allow to use bigger size icons. There is no need to artificially increase the size this way, if they need bigger size can increase the panel height. > 3. Can expose plasmoid.configuration.iconSize to the user. Otherwise can be removed. SystemTray is quite messy in a lot of places. How conveniently, there is a change with some refactoring and cleanup (D26992 <https://phabricator.kde.org/D26992>) waiting for a review :) BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
