hpereiradacosta added inline comments. INLINE COMMENTS
> cblack wrote in breezehelper.cpp:1726 > In testing, I found that this would remain 1 physical pixel regardless of > scale factor. Then shouldn't you divide device pixel ratio ? Also, someone else should double check. To me that does not make sense. Everything else (*everything*) scales with device pixel ratio. Why should this line in particular not scale ? What makes it different from regular separators ? > breezestyle.cpp:886 > + painter->drawLine( > + widget->rect().left() - 100, > + widget->rect().top(), What are these + and -100 numbers ? They sound arbitrary. At the minimum there should be a comment, and an enum to define what this number is. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
