ervin added inline comments.

INLINE COMMENTS

> bport wrote in spellchecking.cpp:88
> Yes, or I can probably also use item like before, and that will be handled 
> for me

That would create other issues I think (not fully sure TBH). Well in any case 
that's an extra level of indirection we don't really need (and it's already 
very confusing as is). Adding the missing usrRead() in the skeleton ctor is 
clearly easier IMO.

> bport wrote in spellchecking.cpp:118
> no because we hold loaded data if we do that, apply button will be 
> deactivated after clicking default

*sigh* OK... KConfigDialogManager is so confusing each time...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to