ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY Normally the `URLButton` shows the full URL in its text. However if this text is overridden to anything else, then the user can't know where the URL points, which may be worrisome, and could be abused by malicious applications to obscure a hostile URL. This patch implements a tooltip shat shows the full URL when the `text` property has been overridden and no longer shows the real URL. TEST PLAN F8131965: vokoscreenNG-2020-02-25_14-35-45.mp4 <https://phabricator.kde.org/F8131965> REPOSITORY R169 Kirigami BRANCH conditionally-show-tooltip-on-url-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D27663 AFFECTED FILES src/controls/LinkButton.qml src/controls/UrlButton.qml To: ngraham, #vdg, #kirigami, mart, apol Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein