meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounter.cpp:111
> This is rather odd. A too eager search and replace? ;-)

Thanks indeed

> ervin wrote in AutomounterSettings.cpp:23
> I guess you could have used `using 
> AutomounterSettingsBase::AutomounterSettingsBase;` in the header instead.

Nice suggestion

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27480

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to