gikari added inline comments. INLINE COMMENTS
> chauvin wrote in configvalueprovider.cpp:50 > I think > > QStringLiteral(", ") > > should be replaced by a space (see my comment > <https://bugs.kde.org/show_bug.cgi?id=333146#c8>) > > however I don't know what will happen in ambigious cases such like: > "DejaVu Sans" + " " + "Condensed Bold" + " " +"11" > and > "DejaVu Sans Condensed" + " " + "Bold" + " " +"11" Comma is important, if not the comma, the GTK would not be able to parse font with spaces in name. Comma fixed that bug: https://bugs.kde.org/show_bug.cgi?id=380980 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven, davidedmundson Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart